Ticket #130 (assigned enhancement)
Sound effects when missions are completed
| Reported by: | knowknowledge | Owned by: | nutomic |
|---|---|---|---|
| Priority: | minor | Milestone: | 0.6.0 |
| Component: | Source | Version: | |
| Keywords: | Missions | Cc: |
Description
The player needs more feedback to know when they have failed or passed a mission. The text of the mission might be interesting, but a nice rewarding *ding* or depressing *bonk* noise could make Missions more interesting.
This should be implemented in the C++ side so that it WILL happen when a mission completes. Mission specific Lua scripts may not always include little things like "User interaction".
Change History
comment:2 Changed 21 months ago by nutomic
I implemented it, but could not test due to console errors (no quotes on german keyboard possible), will have to wait until this is fixed or someone else tests it (mail me for the code if you need it).
We also need sound files for this.
comment:3 Changed 21 months ago by chris
Do you use github? You should branch this code until it's working and do a pull request.
comment:4 Changed 21 months ago by nutomic
Got it working now, are there any naming conventions for the audio files, respectively what audio files should I write into the code? (Assuming it is hardcoded).
I'm not sure how branches work, so I will just add it and commit/push as soon as I know the filename/path.
btw, a mission counted as failed for me when I didn't have enough space for the freight I was supposed to transport (instead of being told I can't do this mission).
comment:5 Changed 21 months ago by nutomic
Code is pushed to git, but the sound files are missing.
(I'm using "Resources/Audio/Effects?/missionSuccess.ogg" and "Resources/Audio/Effects?/missionFailure.ogg")
Guess this should stay open until the sound sare there.
comment:6 Changed 21 months ago by chris
How about one of these:
For success: http://www.freesound.org/people/grunz/sounds/109663/
For failure: http://www.freesound.org/people/Splashdust/sounds/67454/ , http://www.freesound.org/people/Suicidity/sounds/81689/ , http://www.freesound.org/people/Suicidity/sounds/81688/
comment:7 Changed 20 months ago by nutomic
http://www.freesound.org/people/grunz/sounds/109663/ is good, and of the failure sounds, I like http://www.freesound.org/people/Splashdust/sounds/67454/ most.
Do you have an account to get the files and convert them?
You'd just have to put them to the path I mentioned.
And something I forgot, the sounds will only work after the mission failed/suceeded window pops up and is closed again, because it is somehow created by lua, which pauses the game. If the sound should play at the same time as the window opening, that lua code should be moved (to the success/failure function that gets called by c++).
